Networking glitchs sort of fixed.

lib/sounds.py

@@ -3,6 +3,7 @@ from typing import Optional, Self, Type, cast
 from PyQt6.QtCore import (
     QBuffer,
     QByteArray,
+    QCryptographicHash,
     QDir,
     QObject,
     QStandardPaths,
@@ -18,6 +19,7 @@ from PyQt6.QtMultimedia import (
 from PyQt6.QtNetwork import (
     QNetworkAccessManager,
     QNetworkDiskCache,
+    QNetworkReply,
     QNetworkRequest,
 )
 
@@ -85,6 +87,7 @@ class SoundOff(QObject):
         netCache.setCacheDirectory(cacheDir.path())
         self.nam = QNetworkAccessManager()
         self.nam.setCache(netCache)
+        self.nam.finished.connect(self.finished)
         return
 
     @pyqtSlot(QMediaPlayer.Error, str)
@@ -95,7 +98,7 @@ class SoundOff(QObject):
 
     @pyqtSlot(QMediaPlayer.MediaStatus)
     def mediaStatus(self, status: QMediaPlayer.MediaStatus) -> None:
-        print(f"mediaStatus: {status}")
+        # print(f"mediaStatus: {status}")
         if status == QMediaPlayer.MediaStatus.LoadedMedia:
             player: Optional[QMediaPlayer] = cast(QMediaPlayer, self.sender())
             assert player is not None
@@ -104,7 +107,7 @@ class SoundOff(QObject):
 
     @pyqtSlot(QMediaPlayer.PlaybackState)
     def playbackState(self, state: QMediaPlayer.PlaybackState) -> None:
-        print(f"playbackState: {state}")
+        # print(f"playbackState: {state}")
         return
 
     #
@@ -121,10 +124,19 @@ class SoundOff(QObject):
             url = QUrl(url)
         if not self.localPlayer.audioOutput():
             self.localPlayer.setAudioOutput(self.localOutput)
+        if self.virtualPlayer and not self.virtualPlayer.audioOutput():
+            self.virtualPlayer.setAudioOutput(self.virtualOutput)
+        if url != self._lastUrl:
             request = QNetworkRequest(url)
-        self.reply = self.nam.get(request)
+            self.nam.get(request)
-        assert self.reply is not None
+            self._lastUrl = url
-        self.reply.finished.connect(self.finished)
+            return
+        for player in [self.localPlayer, self.virtualPlayer]:
+            if not player:
+                continue
+            player.setPosition(0)
+            if player.mediaStatus() == QMediaPlayer.MediaStatus.LoadedMedia:
+                player.play()
         return
 
     @pyqtSlot()
@@ -135,33 +147,27 @@ class SoundOff(QObject):
     #
     # Network slots
     #
-    _buffer = QBuffer()
+    _storage: dict[QMediaPlayer, QByteArray] = {}
-    _storage = QByteArray()
+    _buffer: dict[QMediaPlayer, QBuffer] = {}
+    _lastUrl = QUrl()
 
-    @pyqtSlot()
+    @pyqtSlot(QNetworkReply)
-    def finished(self) -> None:
+    def finished(self, reply: QNetworkReply) -> None:
-        assert self.reply is not None
+        storage = reply.readAll()
-        self._storage = self.reply.readAll()
+
-        if self.localPlayer.sourceDevice() != self._buffer:
+        crypto = QCryptographicHash(QCryptographicHash.Algorithm.Sha256)
-            self._buffer.setBuffer(self._storage)
+        for player in [self.localPlayer, self.virtualPlayer]:
-            self.localPlayer.setSourceDevice(self._buffer)
+            if not player:
-        self.localPlayer.setPosition(0)
+                continue
-        if (
+            self._storage[player] = QByteArray(storage)
-            self.localPlayer.mediaStatus()
+            crypto.addData(self._storage[player])
-            == QMediaPlayer.MediaStatus.LoadedMedia
+            print(player, crypto.result().toHex())
-        ):
+            crypto.reset()
-            self.localPlayer.play()
+            self._buffer[player] = QBuffer(self._storage[player])
+            url = reply.request().url()
+            player.setSourceDevice(self._buffer[player], url)
+            player.setPosition(0)
+            if player.mediaStatus() == QMediaPlayer.MediaStatus.LoadedMedia:
+                player.play()
                 print("play")
-        if not self.virtualDevice:
-            return
-        if self.virtualPlayer.sourceDevice() != self._buffer:
-            self.virtualPlayer.setSourceDevice(self._buffer)
-        self.virtualPlayer.setPosition(0)
-        if not self.virtualPlayer.audioOutput():
-            self.virtualPlayer.setAudioOutput(self.virtualOutput)
-        if (
-            self.virtualPlayer.mediaStatus()
-            == QMediaPlayer.MediaStatus.LoadedMedia
-        ):
-            self.virtualPlayer.play()
         return